]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
completion: fix typo, add missing args
authorSteven Seungcheol Lee <sc108.lee@samsung.com>
Wed, 15 Feb 2023 04:42:31 +0000 (13:42 +0900)
committerSteven Seungcheol Lee <sc108.lee@samsung.com>
Wed, 15 Feb 2023 05:05:04 +0000 (14:05 +0900)
write-zeros -> write-zeroes
--nmic short name is -m
add missing space
add missing args

Reported-by: Youngjin Jung <yj4369.jung@samsung.com>
Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Co-authored-by: Minsik Jeon <hmi.jeon@samsung.com>
completions/_nvme
completions/bash-nvme-completion.sh

index 591089863e0e8eb181345f04b468b55acef972ad..7702fcc9f0cc3487feb69c308080a552219711ca 100644 (file)
@@ -231,9 +231,23 @@ _nvme () {
                        --dps=':data protection?'
                        -d':alias of --dps'
                        --nmic=':multipath and sharing'
-                       -n':alias of --nmic'
+                       -m':alias of --nmic'
+                       --anagrp-id=':ANA Group Identifier'
+                       -a':alias of --anagrp-id'
+                       --nvmset-id=':NVM Set Identifier'
+                       -i':alias of --nvmset-id'
+                       --block-size=':target block size'
+                       -b':alias of --block-size'
+                       --timeout=':value for timeout'
+                       -t':alias of --timeout'
                        --csi=':command set identifier'
                        -y':alias of --csi'
+                       --lbstm=':logical block storage tag mask'
+                       -l':alias of --lbstm'
+                       --nsze-si=':size of ns (NSZE) in standard SI units'
+                       -S':alias of --nsze-si'
+                       --ncap-si=':capacity of ns (NCAP) in standard SI units'
+                       -C':alias of --ncap-si'
                        )
                        _arguments '*:: :->subcmds'
                        _describe -t commands "nvme create-ns options" _createns
@@ -244,6 +258,8 @@ _nvme () {
                        /dev/nvme':supply a device to use (required)'
                        --namespace-id=':namespace to delete'
                        -n':alias of --namespace-id'
+                       --timeout=':value for timeout'
+                       -t':alias of --timeout'
                        )
                        _arguments '*:: :->subcmds'
                        _describe -t commands "nvme delete-ns options" _deletens
@@ -505,6 +521,8 @@ _nvme () {
                        /dev/nvme':supply a device to use (required)'
                        --namespace-id=':<nsid> of namespace to format (required)'
                        -n':alias of --namespace-id'
+                       --timeout=':value for timeout'
+                       -t':alias of --timeout'
                        --lbaf=':LBA format to apply to namespace (required)'
                        -l':alias of --lbaf'
                        --ses=':secure erase? 0 - no-op (default), 1 - user-data erase, 2 - cryptographic erase'
index c5fbda0035991a49cb9821d7a3a8f9e473e32486..fae3ab40a8087d2a565885a546e02ce6be5bf3ac 100644 (file)
@@ -92,8 +92,9 @@ nvme_list_opts () {
                        ;;
                "create-ns")
                opts+=" --nsze= -s --ncap= -c --flbas= -f \
-                       --dps= -d --nmic= -n --anagrp-id= -a --nvmset-id= -i \
-                       --block-size= -b --timeout= -t--csi= -y"
+                       --dps= -d --nmic= -m --anagrp-id= -a --nvmset-id= -i \
+                       --block-size= -b --timeout= -t --csi= -y --lbstm= -l \
+                       --nsze-si= -S --ncap-si= -C"
                        ;;
                "delete-ns")
                opts+=" -namespace-id= -n --timeout= -t"
@@ -312,7 +313,7 @@ nvme_list_opts () {
                        --dir-type= -T --dir-spec= -S --dsm= -D --show-command -v \
                        --dry-run -w --latency -t"
                        ;;
-               "write-zeros")
+               "write-zeroes")
                opts+=" --namespace-id= -n --start-block= -s \
                        --block-count= -c --deac -d --limited-retry -l \
                        --force-unit-access -f --prinfo= -p --ref-tag= -r \