]> www.infradead.org Git - linux-platform-drivers-x86.git/commitdiff
drm/i915/gvt: Do not reset pv_notified when vGPU transit from D3->D0
authorColin Xu <colin.xu@intel.com>
Thu, 9 Jul 2020 07:09:57 +0000 (15:09 +0800)
committerZhenyu Wang <zhenyuw@linux.intel.com>
Wed, 29 Jul 2020 06:18:32 +0000 (14:18 +0800)
Unlike full initialization like normal boot, guest driver won't
pv_notified GVT when vGPU transit from D3->D0. If pv_notified is reset,
later vGPU operations will trigger enter into failsafe mode.

Considering the fact that vGPU will at least notify GVT pv_notified once
before D3/D0 transition, it's safe to skip reset pv_notified in D3->D0.

To test this feature, make sure S3 is enabled in QEMU parameters:
i440fx: PIIX4_PM.disable_s3=0
q35: ICH9-LPC.disable_s3=0
Also need enable sleep option in guest OS if it's disabled.

v2:
- Revise commit message to more accurate description. (Kevin)
- Split patch by logic. (Zhenyu)

Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Signed-off-by: Hang Yuan <hang.yuan@linux.intel.com>
Signed-off-by: Colin Xu <colin.xu@intel.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20200709071002.247960-3-colin.xu@intel.com
drivers/gpu/drm/i915/gvt/vgpu.c

index fb12448fe353409723954a5cc459e6a76e27a44f..8fa9b31a248401ffc28a0b862827e3da6c4f2fa0 100644 (file)
@@ -579,13 +579,14 @@ void intel_gvt_reset_vgpu_locked(struct intel_vgpu *vgpu, bool dmlr,
                        intel_vgpu_reset_cfg_space(vgpu);
                        /* only reset the failsafe mode when dmlr reset */
                        vgpu->failsafe = false;
-                       vgpu->pv_notified = false;
                        /*
                         * PCI_D0 is set before dmlr, so reset d3_entered here
                         * after done using.
                         */
                        if(vgpu->d3_entered)
                                vgpu->d3_entered = false;
+                       else
+                               vgpu->pv_notified = false;
                }
        }