]> www.infradead.org Git - users/hch/misc.git/commitdiff
ASoC: replace use of system_unbound_wq with system_dfl_wq
authorMarco Crivellari <marco.crivellari@suse.com>
Fri, 5 Sep 2025 09:10:15 +0000 (11:10 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 5 Sep 2025 10:57:52 +0000 (11:57 +0100)
Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistentcy cannot be addressed without refactoring the API.

system_unbound_wq should be the default workqueue so as not to enforce
locality constraints for random work whenever it's not required.

Adding system_dfl_wq to encourage its use when unbound work should be used.

queue_work() / queue_delayed_work() / mod_delayed_work() will now use the
new unbound wq: whether the user still use the old wq a warn will be
printed along with a wq redirect to the new one.

The old system_unbound_wq will be kept for a few release cycles.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Message-ID: <20250905091016.109428-2-marco.crivellari@suse.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm_adsp.c

index 8a1d5cc75d6c23bea3c41738318bcf6ec6aed30c..82c76338df21659d66c3c9c39e42a8bc4803f960 100644 (file)
@@ -1043,7 +1043,7 @@ int wm_adsp_early_event(struct snd_soc_dapm_widget *w,
 
        switch (event) {
        case SND_SOC_DAPM_PRE_PMU:
-               queue_work(system_unbound_wq, &dsp->boot_work);
+               queue_work(system_dfl_wq, &dsp->boot_work);
                break;
        case SND_SOC_DAPM_PRE_PMD:
                wm_adsp_power_down(dsp);