]> www.infradead.org Git - users/hch/block.git/commitdiff
nvme: remove the GENHD_FL_UP check in nvme_ns_remove
authorChristoph Hellwig <hch@lst.de>
Thu, 22 Jul 2021 19:48:43 +0000 (21:48 +0200)
committerChristoph Hellwig <hch@lst.de>
Fri, 6 Aug 2021 06:00:09 +0000 (08:00 +0200)
Early probe failure never reaches nvme_ns_remove, so GENHD_FL_UP must
be set at this point.  Remove the check.

Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c

index dfd9dec0c1f6053b3d5de104d2f0de0c81cfa98a..e24a0143fd87962eb92ecb534d8eae32a0d19feb 100644 (file)
@@ -3826,14 +3826,12 @@ static void nvme_ns_remove(struct nvme_ns *ns)
        nvme_mpath_clear_current_path(ns);
        synchronize_srcu(&ns->head->srcu); /* wait for concurrent submissions */
 
-       if (ns->disk->flags & GENHD_FL_UP) {
-               if (!nvme_ns_head_multipath(ns->head))
-                       nvme_cdev_del(&ns->cdev, &ns->cdev_device);
-               del_gendisk(ns->disk);
-               blk_cleanup_queue(ns->queue);
-               if (blk_get_integrity(ns->disk))
-                       blk_integrity_unregister(ns->disk);
-       }
+       if (!nvme_ns_head_multipath(ns->head))
+               nvme_cdev_del(&ns->cdev, &ns->cdev_device);
+       del_gendisk(ns->disk);
+       blk_cleanup_queue(ns->queue);
+       if (blk_get_integrity(ns->disk))
+               blk_integrity_unregister(ns->disk);
 
        down_write(&ns->ctrl->namespaces_rwsem);
        list_del_init(&ns->list);