]> www.infradead.org Git - users/hch/misc.git/commitdiff
iio: adc: ad7606: exit for invalid fdt dt_schema properties
authorAngelo Dureghello <adureghello@baylibre.com>
Fri, 6 Jun 2025 14:19:20 +0000 (16:19 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 9 Jun 2025 06:45:37 +0000 (07:45 +0100)
Fix ad7606_get_chan_config() fdt parsing function to exit for error in
case of invalid dt_schema values.

Idea is to not proceed when there are values that are not allowed under
the dt_schema.

Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20250606-wip-bl-ad7606-calibration-v9-5-6e014a1f92a2@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad7606.c

index f0c22365f23fa2bf00edddcdd7d608bd1393bf28..e5878974a28293664dd8dbded5fffcea6db31ef3 100644 (file)
@@ -319,15 +319,13 @@ static int ad7606_get_chan_config(struct iio_dev *indio_dev, int ch,
 
                ret = fwnode_property_read_u32(child, "reg", &reg);
                if (ret)
-                       continue;
+                       return ret;
 
                /* channel number (here) is from 1 to num_channels */
-               if (reg < 1 || reg > num_channels) {
-                       dev_warn(dev,
-                                "Invalid channel number (ignoring): %d\n", reg);
-                       continue;
-               }
+               if (reg < 1 || reg > num_channels)
+                       return -EINVAL;
 
+               /* Loop until we are in the right channel. */
                if (reg != (ch + 1))
                        continue;