]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
clk: at91: Use of_property_count_u32_elems() to get property length
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 20:14:02 +0000 (14:14 -0600)
committerStephen Boyd <sboyd@kernel.org>
Fri, 2 Aug 2024 23:53:00 +0000 (16:53 -0700)
Replace of_get_property() with the type specific
of_property_count_u32_elems() to get the property length.

This is part of a larger effort to remove callers of of_get_property()
and similar functions. of_get_property() leaks the DT property data
pointer which is a problem for dynamically allocated nodes which may
be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20240731201407.1838385-7-robh@kernel.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/at91/dt-compat.c

index a32dc2111b900e3aa12efbbdfa79ab2308f0fe75..f5a5f9ba76346ba159fe9c8b9f940626c9f6cd99 100644 (file)
@@ -563,9 +563,10 @@ of_at91_clk_pll_get_characteristics(struct device_node *np)
        if (num_cells < 2 || num_cells > 4)
                return NULL;
 
-       if (!of_get_property(np, "atmel,pll-clk-output-ranges", &tmp))
+       num_output = of_property_count_u32_elems(np, "atmel,pll-clk-output-ranges");
+       if (num_output <= 0)
                return NULL;
-       num_output = tmp / (sizeof(u32) * num_cells);
+       num_output /= num_cells;
 
        characteristics = kzalloc(sizeof(*characteristics), GFP_KERNEL);
        if (!characteristics)