]> www.infradead.org Git - users/hch/misc.git/commitdiff
ASoC: SOF: imx: Remove error print for devm_add_action_or_reset()
authorWaqar Hameed <waqar.hameed@axis.com>
Tue, 5 Aug 2025 09:33:32 +0000 (11:33 +0200)
committerMark Brown <broonie@kernel.org>
Sun, 10 Aug 2025 20:09:14 +0000 (21:09 +0100)
When `devm_add_action_or_reset()` fails, it is due to a failed memory
allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
anything when error is `-ENOMEM`. Therefore, remove the useless call to
`dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
return the value instead.

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Link: https://patch.msgid.link/pndpldam7tf.a.out@axis.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/imx/imx-common.c

index f00b381cec3b4aa03c76068bac120582fec64d0a..1757539a6a28339a8f944699813f961c8968054f 100644 (file)
@@ -382,7 +382,7 @@ static int imx_probe(struct snd_sof_dev *sdev)
                                       imx_unregister_action,
                                       sdev);
        if (ret)
-               return dev_err_probe(sdev->dev, ret, "failed to add devm action\n");
+               return ret;
 
        common->ipc_handle = dev_get_drvdata(&common->ipc_dev->dev);
        if (!common->ipc_handle)