test-patchset: don't skip email when pre-patch build fails

Currently, whenever the pre-patched kernel fails to build, we
don't show the results for the post-patched kernel. This is faulty,
because we could easily be providing a patch which fixes the issue.
Instead, we should show the results for the failed build, but still
continue. If the post-patched kernel fails to build there is little need
to show a complex diff, but we can at least show the results for both
the pre-patched and post-patched kernel.

This patch also additionally adds --keep-going to the pre-patched kernel
in order to obtain more data for comparison.

Artem: add a commentary

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

diff --git a/aiaiai-test-patchset b/aiaiai-test-patchset
index 88078100630f2aabb19a70a41258ca2f2df0cab6..3e82b73deaa2d0f13602a4a79bb88f1aeb3202de 100755 (executable)
--- a/aiaiai-test-patchset
+++ b/aiaiai-test-patchset
@@ -176,9 +176,12 @@ test_configuration()
        local log1="$logdir1/$config"
        local obj1="$tmpdir1/obj.$config"
 
+       # Note, we use the --keep-going option assuming that the base commit
+       # build may fail, which is OK for continuing as long as the patches
+       # under test fix it.
        aiaiai-make-kernel $verbose $sparse $smatch $cppcheck $coccinelle -o "$obj1" \
                --check-only "$mod_files" -j "$jobs" $arch_opt -D "$defconfig" \
-               -O "$log1.stdout.log" -E "$log1.stderr.log" \
+               -O "$log1.stdout.log" -E "$log1.stderr.log" --keep-going \
                ${kmake_opts:+-M "$kmake_opts"} -- "$cloned_kernel1" all
 
        verbose "Done with non-patched kernel"
@@ -453,7 +456,7 @@ for defconfig in $defconfigs; do
        # Make kernel appends a "FAILURE" string at the end when builds fail
        if build_failed "$log1"; then
                build_failure "$defconfig" "$commit_id1" < "$log1"
-               continue
+               print_separator
        fi
 
        if build_failed "$log2"; then