]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
clk: meson-axg: fix potential NULL dereference in axg_clkc_probe()
authorweiyongjun (A) <weiyongjun1@huawei.com>
Fri, 5 Jan 2018 01:50:59 +0000 (01:50 +0000)
committerStephen Boyd <sboyd@codeaurora.org>
Wed, 10 Jan 2018 21:24:36 +0000 (13:24 -0800)
platform_get_resource() may return NULL, add proper
check to avoid potential NULL dereferencing.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/meson/axg.c

index d883bef49eb7008f3814eb20fe8df63f3f31f6a1..1294f3ad7cd5968434b8feda4751c89a52759656 100644 (file)
@@ -879,6 +879,8 @@ static int axg_clkc_probe(struct platform_device *pdev)
 
        /*  Generic clocks and PLLs */
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+       if (!res)
+               return -EINVAL;
        clk_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
        if (!clk_base) {
                dev_err(&pdev->dev, "Unable to map clk base\n");