]> www.infradead.org Git - linux-platform-drivers-x86.git/commitdiff
platform/x86: amd-pmc: Check s0i3 cycle status
authorSanket Goswami <Sanket.Goswami@amd.com>
Thu, 16 Sep 2021 12:41:30 +0000 (18:11 +0530)
committerHans de Goede <hdegoede@redhat.com>
Thu, 16 Sep 2021 13:26:36 +0000 (15:26 +0200)
As the PM firmware returns the status of the last s0i3 in the smu_metrics
structure, the existing name "s0i3_cyclecount" seems to be a misnomer.
Change it accordingly to "s0i3_last_entry_status".

Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20210916124130.2581-1-Sanket.Goswami@amd.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/amd-pmc.c

index d6a7c896ac8661c166368a7326c0e410dbc04f5d..8c2016e02470d24226c4507c3335fcef447dd6ad 100644 (file)
@@ -133,7 +133,7 @@ static inline void amd_pmc_reg_write(struct amd_pmc_dev *dev, int reg_offset, u3
 struct smu_metrics {
        u32 table_version;
        u32 hint_count;
-       u32 s0i3_cyclecount;
+       u32 s0i3_last_entry_status;
        u32 timein_s0i2;
        u64 timeentering_s0i3_lastcapture;
        u64 timeentering_s0i3_totaltime;
@@ -162,7 +162,8 @@ static int smu_fw_info_show(struct seq_file *s, void *unused)
        seq_puts(s, "\n=== SMU Statistics ===\n");
        seq_printf(s, "Table Version: %d\n", table.table_version);
        seq_printf(s, "Hint Count: %d\n", table.hint_count);
-       seq_printf(s, "S0i3 Cycle Count: %d\n", table.s0i3_cyclecount);
+       seq_printf(s, "Last S0i3 Status: %s\n", table.s0i3_last_entry_status ? "Success" :
+                  "Unknown/Fail");
        seq_printf(s, "Time (in us) to S0i3: %lld\n", table.timeentering_s0i3_lastcapture);
        seq_printf(s, "Time (in us) in S0i3: %lld\n", table.timein_s0i3_lastcapture);