]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
net: ena: Remove unnecessary pci_set_drvdata()
authorWei Yongjun <weiyj.lk@gmail.com>
Mon, 15 Aug 2016 22:50:34 +0000 (22:50 +0000)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 23:12:23 +0000 (18:12 -0500)
Orabug: 25307221

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 557bc7d44d52d52374bc72e9cc3b0beb41026886)
Signed-off-by: Brian Maly <brian.maly@oracle.com>
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
drivers/net/ethernet/amazon/ena/ena_netdev.c

index 94790df2d5594ec91d172bf29512bc71df3bcdf9..499a22b165f1ba99ad2bbfd2ebfa64cbdcfd8168 100644 (file)
@@ -3060,7 +3060,6 @@ err_device_destroy:
 err_free_region:
        ena_release_bars(ena_dev, pdev);
 err_free_ena_dev:
-       pci_set_drvdata(pdev, NULL);
        vfree(ena_dev);
 err_disable_device:
        pci_disable_device(pdev);
@@ -3156,8 +3155,6 @@ static void ena_remove(struct pci_dev *pdev)
 
        ena_release_bars(ena_dev, pdev);
 
-       pci_set_drvdata(pdev, NULL);
-
        pci_disable_device(pdev);
 
        ena_com_destroy_interrupt_moderation(ena_dev);