]> www.infradead.org Git - users/hch/misc.git/commitdiff
net/mlx5e: Change eth_proto parameter naming
authorShahar Shitrit <shshitrit@nvidia.com>
Wed, 19 Feb 2025 11:41:11 +0000 (13:41 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 21 Feb 2025 01:36:09 +0000 (17:36 -0800)
eth_proto_cap parameter represents the supported link modes,
while eth_proto_admin refers to the configured ones.

The function get_advertising() retrieves the configured link
modes, thus we update its parameter name to eth_proto_admin.

Signed-off-by: Shahar Shitrit <shshitrit@nvidia.com>
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20250219114112.403808-5-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c

index 6dab58ab50ac3acfd45103644dd5832a357bbd4f..712171dd07c706c0fdb7e5219ef195d46e9faef6 100644 (file)
@@ -1115,12 +1115,12 @@ static void get_supported(struct mlx5_core_dev *mdev, u32 eth_proto_cap,
        ethtool_link_ksettings_add_link_mode(link_ksettings, supported, Pause);
 }
 
-static void get_advertising(u32 eth_proto_cap, u8 tx_pause, u8 rx_pause,
+static void get_advertising(u32 eth_proto_admin, u8 tx_pause, u8 rx_pause,
                            struct ethtool_link_ksettings *link_ksettings,
                            bool ext)
 {
        unsigned long *advertising = link_ksettings->link_modes.advertising;
-       ptys2ethtool_process_link(eth_proto_cap, ext, true, advertising);
+       ptys2ethtool_process_link(eth_proto_admin, ext, true, advertising);
        if (rx_pause)
                ethtool_link_ksettings_add_link_mode(link_ksettings, advertising, Pause);
        if (tx_pause ^ rx_pause)