]> www.infradead.org Git - users/hch/misc.git/commitdiff
media: camss: Remove custom .release fop()
authorJacopo Mondi <jacopo.mondi@ideasonboard.com>
Sun, 10 Aug 2025 01:30:02 +0000 (04:30 +0300)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 06:33:32 +0000 (08:33 +0200)
The 'file->private_data' pointer is reset in the vb2_fop_release()
call path. For this reason a custom handler for the .release
file operation is not needed and the driver can use
vb2_fop_release() directly.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/qcom/camss/camss-video.c

index c5d02f9ebc6aa9bfd6910944f3d40a2e5f0a908f..831486e14754ab3a24b077e21be14ea3169220a4 100644 (file)
@@ -604,20 +604,11 @@ static const struct v4l2_ioctl_ops msm_vid_ioctl_ops = {
  * V4L2 file operations
  */
 
-static int video_release(struct file *file)
-{
-       vb2_fop_release(file);
-
-       file->private_data = NULL;
-
-       return 0;
-}
-
 static const struct v4l2_file_operations msm_vid_fops = {
        .owner          = THIS_MODULE,
        .unlocked_ioctl = video_ioctl2,
        .open           = v4l2_fh_open,
-       .release        = video_release,
+       .release        = vb2_fop_release,
        .poll           = vb2_fop_poll,
        .mmap           = vb2_fop_mmap,
        .read           = vb2_fop_read,