usb: typec: Add the missed altmode_id_remove() in typec_register_altmode()

commit 03026197bb657d784220b040c6173267a0375741 upstream.

typec_register_altmode() misses to call altmode_id_remove() in an error
path. Add the missed function call to fix it.

Fixes: 8a37d87d72f0 ("usb: typec: Bus type for alternate modes")
Cc: stable <stable@vger.kernel.org>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Link: https://lore.kernel.org/r/20210617073226.47599-1-jingxiangfeng@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index 1916ee1600b47c201203b35d7eb7664b636619dd..8dae6ff2377ce2aa5a51d5503ab01a4599bb4e38 100644 (file)
--- a/drivers/usb/typec/class.c
+++ b/drivers/usb/typec/class.c
@@ -481,8 +481,10 @@ typec_register_altmode(struct device *parent,
        int ret;
 
        alt = kzalloc(sizeof(*alt), GFP_KERNEL);
-       if (!alt)
+       if (!alt) {
+               altmode_id_remove(parent, id);
                return ERR_PTR(-ENOMEM);
+       }
 
        alt->adev.svid = desc->svid;
        alt->adev.mode = desc->mode;