]> www.infradead.org Git - linux-platform-drivers-x86.git/commitdiff
drbd: use DEFINE_SPINLOCK() for spinlock
authorGuobin Huang <huangguobin4@huawei.com>
Tue, 6 Apr 2021 12:09:48 +0000 (20:09 +0800)
committerJens Axboe <axboe@kernel.dk>
Tue, 6 Apr 2021 15:31:42 +0000 (09:31 -0600)
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
Link: https://lore.kernel.org/r/1617710988-49205-1-git-send-email-huangguobin4@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/drbd/drbd_main.c

index 2ca126bbbc37787a0e6bbf7456dcb785b5d5c7f4..de463773b530410a9be33f86ac593d4f91ce9401 100644 (file)
@@ -125,7 +125,7 @@ struct bio_set drbd_io_bio_set;
         member of struct page.
  */
 struct page *drbd_pp_pool;
-spinlock_t   drbd_pp_lock;
+DEFINE_SPINLOCK(drbd_pp_lock);
 int          drbd_pp_vacant;
 wait_queue_head_t drbd_pp_wait;
 
@@ -2160,9 +2160,6 @@ static int drbd_create_mempools(void)
        if (ret)
                goto Enomem;
 
-       /* drbd's page pool */
-       spin_lock_init(&drbd_pp_lock);
-
        for (i = 0; i < number; i++) {
                page = alloc_page(GFP_HIGHUSER);
                if (!page)