crypto: cavium - Fix couple of static checker errors

Fix the following smatch errors
cptvf_reqmanager.c:333 do_post_process() warn: variable dereferenced
before check 'cptvf'
cptvf_main.c:825 cptvf_remove() error: we previously assumed 'cptvf'
could be null

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: George Cherian <george.cherian@cavium.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/cavium/cpt/cptvf_main.c b/drivers/crypto/cavium/cpt/cptvf_main.c
index aac2966ff8d92dbaa2974c591cb46bcf690326a0..e50872e666d655b988e6b9df6d1e4358f05ffba3 100644 (file)
--- a/drivers/crypto/cavium/cpt/cptvf_main.c
+++ b/drivers/crypto/cavium/cpt/cptvf_main.c
@@ -815,8 +815,10 @@ static void cptvf_remove(struct pci_dev *pdev)
 {
        struct cpt_vf *cptvf = pci_get_drvdata(pdev);
 
-       if (!cptvf)
+       if (!cptvf) {
                dev_err(&pdev->dev, "Invalid CPT-VF device\n");
+               return;
+       }
 
        /* Convey DOWN to PF */
        if (cptvf_send_vf_down(cptvf)) {

diff --git a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
index 7f57f30f88636c6e9908cab029f6c46572f9bbc7..169e66231bcf15c4500507d9d88536f3cf4626a4 100644 (file)
--- a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
+++ b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
@@ -330,8 +330,8 @@ void do_post_process(struct cpt_vf *cptvf, struct cpt_info_buffer *info)
 {
        struct pci_dev *pdev = cptvf->pdev;
 
-       if (!info || !cptvf) {
-               dev_err(&pdev->dev, "Input params are incorrect for post processing\n");
+       if (!info) {
+               dev_err(&pdev->dev, "incorrect cpt_info_buffer for post processing\n");
                return;
        }