]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
RISC-V: KVM: Fix pte settings within kvm_riscv_gstage_ioremap()
authorFangyu Yu <fangyu.yu@linux.alibaba.com>
Thu, 7 Aug 2025 07:07:29 +0000 (15:07 +0800)
committerAnup Patel <anup@brainfault.org>
Mon, 25 Aug 2025 04:56:16 +0000 (10:26 +0530)
Currently, kvm_riscv_gstage_ioremap() is used to map IMSIC gpa to the
spa of IMSIC guest interrupt file.

The PAGE_KERNEL_IO property includes global setting whereas it does not
include user mode settings, so when accessing the IMSIC address in the
virtual machine, a guest page fault will occur, this is not expected.

According to the RISC-V Privileged Architecture Spec, for G-stage address
translation, all memory accesses are considered to be user-level accesses
as though executed in U-mode.

Fixes: 659ad6d82c31 ("RISC-V: KVM: Use PAGE_KERNEL_IO in kvm_riscv_gstage_ioremap()")
Signed-off-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>
Reviewed-by: Radim Krčmář <rkrcmar@ventanamicro.com>
Reviewed-by: Nutty Liu <nutty.liu@hotmail.com>
Link: https://lore.kernel.org/r/20250807070729.89701-1-fangyu.yu@linux.alibaba.com
Signed-off-by: Anup Patel <anup@brainfault.org>
arch/riscv/kvm/mmu.c

index a1c3b2ec1dde54c65bd72e64bc2e3b252cbf5f6d..525fb5a330c0d20b71ee8e27092efe05dc4cd88f 100644 (file)
@@ -39,6 +39,7 @@ int kvm_riscv_mmu_ioremap(struct kvm *kvm, gpa_t gpa, phys_addr_t hpa,
                          unsigned long size, bool writable, bool in_atomic)
 {
        int ret = 0;
+       pgprot_t prot;
        unsigned long pfn;
        phys_addr_t addr, end;
        struct kvm_mmu_memory_cache pcache = {
@@ -55,10 +56,12 @@ int kvm_riscv_mmu_ioremap(struct kvm *kvm, gpa_t gpa, phys_addr_t hpa,
 
        end = (gpa + size + PAGE_SIZE - 1) & PAGE_MASK;
        pfn = __phys_to_pfn(hpa);
+       prot = pgprot_noncached(PAGE_WRITE);
 
        for (addr = gpa; addr < end; addr += PAGE_SIZE) {
                map.addr = addr;
-               map.pte = pfn_pte(pfn, PAGE_KERNEL_IO);
+               map.pte = pfn_pte(pfn, prot);
+               map.pte = pte_mkdirty(map.pte);
                map.level = 0;
 
                if (!writable)