]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
USB: host: ehci-mxc: Add error handling in ehci_mxc_drv_probe()
authorTang Bin <tangbin@cmss.chinamobile.com>
Wed, 13 May 2020 13:26:47 +0000 (21:26 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jun 2020 13:41:53 +0000 (15:41 +0200)
[ Upstream commit d49292025f79693d3348f8e2029a8b4703be0f0a ]

The function ehci_mxc_drv_probe() does not perform sufficient error
checking after executing platform_get_irq(), thus fix it.

Fixes: 7e8d5cd93fac ("USB: Add EHCI support for MX27 and MX31 based boards")
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Link: https://lore.kernel.org/r/20200513132647.5456-1-tangbin@cmss.chinamobile.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/host/ehci-mxc.c

index c7a9b31eeaeff03a6c422d47c476fda4b03e5cb0..637079a350032307dbea12018f1df59334bacfe5 100644 (file)
@@ -63,6 +63,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
        }
 
        irq = platform_get_irq(pdev, 0);
+       if (irq < 0)
+               return irq;
 
        hcd = usb_create_hcd(&ehci_mxc_hc_driver, dev, dev_name(dev));
        if (!hcd)