]> www.infradead.org Git - users/mchehab/rasdaemon.git/commitdiff
ras-mce-handler: fix mcgstatus message print
authorMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 11 Jun 2019 18:01:38 +0000 (15:01 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 11 Jun 2019 18:01:38 +0000 (15:01 -0300)
As warned by clang, the test there is wrong:

ras-mce-handler.c:344:9: warning: address of array 'e->mcgstatus_msg' will always evaluate to 'true' [-Wpointer-bool-conversion]
        if (e->mcgstatus_msg)
        ~~  ~~~^~~~~~~~~~~~~

Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
ras-mce-handler.c

index c11d489de0d1ba6902b2c3ed272d245d8e16c749..7ab233508ebac2fd86f8cc3eb2d8d08d895acc05 100644 (file)
@@ -341,7 +341,7 @@ static void report_mce_event(struct ras_events *ras,
        if (e->ipid)
                trace_seq_printf(s, ", ipid= %llx", (long long)e->ipid);
 
-       if (e->mcgstatus_msg)
+       if (*e->mcgstatus_msg)
                trace_seq_printf(s, ", %s", e->mcgstatus_msg);
        else
                trace_seq_printf(s, ", mcgstatus= %llx",