]> www.infradead.org Git - nvme.git/commitdiff
selftests/bpf: Add XDP_UMEM_TX_METADATA_LEN to XSK TX metadata test
authorStanislav Fomichev <sdf@fomichev.me>
Sat, 13 Jul 2024 01:52:52 +0000 (18:52 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 25 Jul 2024 09:57:33 +0000 (11:57 +0200)
This flag is now required to use tx_metadata_len.

Fixes: 40808a237d9c ("selftests/bpf: Add TX side to xdp_metadata")
Reported-by: Julian Schindel <mail@arctic-alpaca.de>
Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Link: https://lore.kernel.org/bpf/20240713015253.121248-3-sdf@fomichev.me
tools/include/uapi/linux/if_xdp.h
tools/testing/selftests/bpf/prog_tests/xdp_metadata.c

index 638c606dfa74f3848500ac3d8d85a668bad015fe..2f082b01ff2284920d1390437aec936c76f32163 100644 (file)
  */
 #define XDP_UMEM_TX_SW_CSUM            (1 << 1)
 
+/* Request to reserve tx_metadata_len bytes of per-chunk metadata.
+ */
+#define XDP_UMEM_TX_METADATA_LEN       (1 << 2)
+
 struct sockaddr_xdp {
        __u16 sxdp_family;
        __u16 sxdp_flags;
index f76b5d67a3eefb7700fe3d8d7bb412824814f498..c87ee2bf558c1a7fb726cae0aa7b3d3735fb1aac 100644 (file)
@@ -68,7 +68,8 @@ static int open_xsk(int ifindex, struct xsk *xsk)
                .fill_size = XSK_RING_PROD__DEFAULT_NUM_DESCS,
                .comp_size = XSK_RING_CONS__DEFAULT_NUM_DESCS,
                .frame_size = XSK_UMEM__DEFAULT_FRAME_SIZE,
-               .flags = XDP_UMEM_UNALIGNED_CHUNK_FLAG | XDP_UMEM_TX_SW_CSUM,
+               .flags = XDP_UMEM_UNALIGNED_CHUNK_FLAG | XDP_UMEM_TX_SW_CSUM |
+                        XDP_UMEM_TX_METADATA_LEN,
                .tx_metadata_len = sizeof(struct xsk_tx_metadata),
        };
        __u32 idx;