]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
serial: 8250_ni: Remove duplicate mapping
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 21 Mar 2025 18:20:13 +0000 (20:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Apr 2025 14:51:19 +0000 (16:51 +0200)
UPF_IOREMAP is for serial core to map the resource on behalf of the
driver. No need to perform this explicitly in the driver.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Chaitanya Vadrevu <chaitanya.vadrevu@emerson.com>
Reviewed-by: Chaitanya Vadrevu <chaitanya.vadrevu@emerson.com>
Link: https://lore.kernel.org/r/20250321182119.454507-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_ni.c

index 03e838f440bec482e66f2fdcbd9b26df82a5dfb8..562f7f29e2096c3225e4238b29b4bc480a64774f 100644 (file)
@@ -239,11 +239,6 @@ static int ni16550_get_regs(struct platform_device *pdev,
                port->mapsize = resource_size(regs);
                port->flags |= UPF_IOREMAP;
 
-               port->membase = devm_ioremap(&pdev->dev, port->mapbase,
-                                            port->mapsize);
-               if (!port->membase)
-                       return -ENOMEM;
-
                return 0;
        }