]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
lan78xx: remove redundant statement in lan78xx_get_eee
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 5 Jan 2024 22:21:52 +0000 (23:21 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 9 Jan 2024 03:17:50 +0000 (19:17 -0800)
eee_active is set by phy_ethtool_get_eee() already, using the same
logic plus an additional check against link speed/duplex values.
See genphy_c45_eee_is_active() for details.
So we can remove this line.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/b086b296-0a1b-42d4-8e2b-ef6682598185@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/lan78xx.c

index 5add4145d9fc1220dd671ecda57d58e60172b773..a6d653ff552a261ca50d331dd7d7aa875ca3c362 100644 (file)
@@ -1691,8 +1691,6 @@ static int lan78xx_get_eee(struct net_device *net, struct ethtool_eee *edata)
        ret = lan78xx_read_reg(dev, MAC_CR, &buf);
        if (buf & MAC_CR_EEE_EN_) {
                edata->eee_enabled = true;
-               edata->eee_active = !!(edata->advertised &
-                                      edata->lp_advertised);
                edata->tx_lpi_enabled = true;
                /* EEE_TX_LPI_REQ_DLY & tx_lpi_timer are same uSec unit */
                ret = lan78xx_read_reg(dev, EEE_TX_LPI_REQ_DLY, &buf);