x86/pci: Rename acpi_mcfg_check_entry() to acpi_mcfg_valid_entry()

"acpi_mcfg_check_entry()" doesn't give a hint about what the return value
means.  Rename it to "acpi_mcfg_valid_entry()", convert the return value to
bool, and update the return values and callers to match so testing
"if (acpi_mcfg_valid_entry())" makes sense.

Link: https://lore.kernel.org/r/20231121183643.249006-6-helgaas@kernel.org
Tested-by: Tomasz Pala <gotar@polanet.pl>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c
index 896cc11013bd695bc9a2f7a25525e6dd16572724..91fd7921d2211620c15e559779e7c7af09e0b87c 100644 (file)
--- a/arch/x86/pci/mmconfig-shared.c
+++ b/arch/x86/pci/mmconfig-shared.c
@@ -576,22 +576,22 @@ static void __init pci_mmcfg_reject_broken(int early)
        }
 }
 
-static int __init acpi_mcfg_check_entry(struct acpi_table_mcfg *mcfg,
-                                       struct acpi_mcfg_allocation *cfg)
+static bool __init acpi_mcfg_valid_entry(struct acpi_table_mcfg *mcfg,
+                                        struct acpi_mcfg_allocation *cfg)
 {
        if (cfg->address < 0xFFFFFFFF)
-               return 0;
+               return true;
 
        if (!strncmp(mcfg->header.oem_id, "SGI", 3))
-               return 0;
+               return true;
 
        if ((mcfg->header.revision >= 1) && (dmi_get_bios_year() >= 2010))
-               return 0;
+               return true;
 
        pr_err("ECAM at %#llx for %04x [bus %02x-%02x] is above 4GB, ignored\n",
               cfg->address, cfg->pci_segment, cfg->start_bus_number,
               cfg->end_bus_number);
-       return -EINVAL;
+       return false;
 }
 
 static int __init pci_parse_mcfg(struct acpi_table_header *header)
@@ -622,7 +622,7 @@ static int __init pci_parse_mcfg(struct acpi_table_header *header)
        cfg_table = (struct acpi_mcfg_allocation *) &mcfg[1];
        for (i = 0; i < entries; i++) {
                cfg = &cfg_table[i];
-               if (acpi_mcfg_check_entry(mcfg, cfg)) {
+               if (!acpi_mcfg_valid_entry(mcfg, cfg)) {
                        free_all_mmcfg();
                        return -ENODEV;
                }