]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
crypto: hisilicon/qm - fix incorrect parameters usage
authorWeili Qian <qianweili@huawei.com>
Sat, 24 Sep 2022 10:14:42 +0000 (18:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:29 +0000 (13:32 +0100)
[ Upstream commit f57e292897cac13b6ddee078aea21173b234ecb7 ]

In qm_get_xqc_depth(), parameters low_bits and high_bits save
the values of the corresponding bits. However, the values saved by the
two parameters are opposite. As a result, the values returned to the
callers are incorrect.

Fixes: 129a9f340172 ("crypto: hisilicon/qm - get qp num and depth from hardware registers")
Signed-off-by: Weili Qian <qianweili@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/hisilicon/qm.c

index 8b387de69d229b7cb6059a6bc5094e277a4be16b..c7e7fc49ec067e197d6e91eedbeaf4baf8708e55 100644 (file)
@@ -909,8 +909,8 @@ static void qm_get_xqc_depth(struct hisi_qm *qm, u16 *low_bits,
        u32 depth;
 
        depth = hisi_qm_get_hw_info(qm, qm_basic_info, type, qm->cap_ver);
-       *high_bits = depth & QM_XQ_DEPTH_MASK;
-       *low_bits = (depth >> QM_XQ_DEPTH_SHIFT) & QM_XQ_DEPTH_MASK;
+       *low_bits = depth & QM_XQ_DEPTH_MASK;
+       *high_bits = (depth >> QM_XQ_DEPTH_SHIFT) & QM_XQ_DEPTH_MASK;
 }
 
 static u32 qm_get_irq_num(struct hisi_qm *qm)