]> www.infradead.org Git - users/hch/xfsprogs.git/commitdiff
libxfs: complain when write IOs fail
authorDarrick J. Wong <darrick.wong@oracle.com>
Sun, 1 Mar 2020 17:33:38 +0000 (12:33 -0500)
committerEric Sandeen <sandeen@sandeen.net>
Sun, 1 Mar 2020 17:33:38 +0000 (12:33 -0500)
Complain whenever a metadata write fails.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Allison Collins <allison.henderson@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
libxfs/rdwr.c

index 92281d586212d6e97c9c427e138bf3517142f66c..4c021316ab9682adb6b03862ff94037708aa7b7a 100644 (file)
@@ -1156,7 +1156,12 @@ libxfs_writebufr(xfs_buf_t *bp)
                        (long long)LIBXFS_BBTOOFF64(bp->b_bn),
                        (long long)bp->b_bn, bp, bp->b_error);
 #endif
-       if (!bp->b_error) {
+       if (bp->b_error) {
+               fprintf(stderr,
+       _("%s: write failed on %s bno 0x%llx/0x%x, err=%d\n"),
+                       __func__, bp->b_ops->name,
+                       (long long)bp->b_bn, bp->b_bcount, -bp->b_error);
+       } else {
                bp->b_flags |= LIBXFS_B_UPTODATE;
                bp->b_flags &= ~(LIBXFS_B_DIRTY | LIBXFS_B_EXIT |
                                 LIBXFS_B_UNCHECKED);