ALSA: ump: Don't update FB name for static blocks

When a device tries to update the FB name string even if its Endpoint
is declared as static, we should skip it, just already done for the FB
info update reply.

Fixes: 37e0e14128e0 ("ALSA: ump: Support UMP Endpoint and Function Block parsing")
Cc: <stable@vger.kernel.org>
Link: https://patch.msgid.link/20240722135929.8612-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/core/ump.c b/sound/core/ump.c
index 3f61220c23b4ec028faddd63bff776a91cc8067c..b325fcfa77d067e1bc9fe32fb6e0916285c17272 100644 (file)
--- a/sound/core/ump.c
+++ b/sound/core/ump.c
@@ -806,6 +806,13 @@ static int ump_handle_fb_name_msg(struct snd_ump_endpoint *ump,
        if (!fb)
                return -ENODEV;
 
+       if (ump->parsed &&
+           (ump->info.flags & SNDRV_UMP_EP_INFO_STATIC_BLOCKS)) {
+               ump_dbg(ump, "Skipping static FB name update (blk#%d)\n",
+                       fb->info.block_id);
+               return 0;
+       }
+
        ret = ump_append_string(ump, fb->info.name, sizeof(fb->info.name),
                                buf->raw, 3);
        /* notify the FB name update to sequencer, too */