]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/amdgpu/vpe: fix insert_nop ops
authorLang Yu <Lang.Yu@amd.com>
Sat, 7 Oct 2023 02:13:49 +0000 (10:13 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 13 Oct 2023 14:58:33 +0000 (10:58 -0400)
Avoid infinite loop when count is 0.
This is missed in rebase.

Signed-off-by: Lang Yu <Lang.Yu@amd.com>
Reviewed-by: Yifan Zhang <yifan1.zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c

index bb74478098bb1a2cb4dac44618b8dcd62c738ad2..e81579708e966203b44ecd70cced4d0ea4dd637a 100644 (file)
@@ -240,11 +240,12 @@ static void vpe_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count)
 {
        int i;
 
-       amdgpu_ring_write(ring, ring->funcs->nop |
+       for (i = 0; i < count; i++)
+               if (i == 0)
+                       amdgpu_ring_write(ring, ring->funcs->nop |
                                VPE_CMD_NOP_HEADER_COUNT(count - 1));
-
-       for (i = 0; i < count - 1; i++)
-               amdgpu_ring_write(ring, 0);
+               else
+                       amdgpu_ring_write(ring, ring->funcs->nop);
 }
 
 static uint64_t vpe_get_csa_mc_addr(struct amdgpu_ring *ring, uint32_t vmid)