]> www.infradead.org Git - users/hch/configfs.git/commitdiff
net: ethernet: use ip_hdrlen() instead of bit shift
authorMoon Yeounsu <yyyynoom@gmail.com>
Wed, 7 Aug 2024 10:07:21 +0000 (19:07 +0900)
committerDavid S. Miller <davem@davemloft.net>
Sun, 11 Aug 2024 03:41:15 +0000 (04:41 +0100)
`ip_hdr(skb)->ihl << 2` is the same as `ip_hdrlen(skb)`
Therefore, we should use a well-defined function not a bit shift
to find the header length.

It also compresses two lines to a single line.

Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com>
Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/jme.c

index b06e245629739f6f16005a51e181ce057d3e8857..d8be0e4dcb072b8cf8e8d26a22173829de3d40c8 100644 (file)
@@ -946,15 +946,13 @@ jme_udpsum(struct sk_buff *skb)
        if (skb->protocol != htons(ETH_P_IP))
                return csum;
        skb_set_network_header(skb, ETH_HLEN);
-       if ((ip_hdr(skb)->protocol != IPPROTO_UDP) ||
-           (skb->len < (ETH_HLEN +
-                       (ip_hdr(skb)->ihl << 2) +
-                       sizeof(struct udphdr)))) {
+
+       if (ip_hdr(skb)->protocol != IPPROTO_UDP ||
+           skb->len < (ETH_HLEN + ip_hdrlen(skb) + sizeof(struct udphdr))) {
                skb_reset_network_header(skb);
                return csum;
        }
-       skb_set_transport_header(skb,
-                       ETH_HLEN + (ip_hdr(skb)->ihl << 2));
+       skb_set_transport_header(skb, ETH_HLEN + ip_hdrlen(skb));
        csum = udp_hdr(skb)->check;
        skb_reset_transport_header(skb);
        skb_reset_network_header(skb);