ras-events: don't use extern inside a C file

Fix a checkpatch warning:

	ras-events.c:66: WARNING:AVOID_EXTERNS: externs should be avoided in .c files

by better handing how checks_inside var is handled.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/ras-events.c b/ras-events.c
index 81535e8fd0f43320c9f31a9f75b00e60443065b5..ad85bcf6bcefe91ffffc6968a4d194da6aa54b05 100644 (file)
--- a/ras-events.c
+++ b/ras-events.c
@@ -63,7 +63,7 @@
        #define ENDIAN KBUFFER_ENDIAN_BIG
 #endif
 
-extern char *choices_disable;
+char *choices_disable;
 
 static const struct event_trigger event_triggers[] = {
        { "mc_event", &mc_event_trigger_setup },

diff --git a/ras-events.h b/ras-events.h
index 135219e77e1015756e741ce25ba7b92728374d77..c94bdd633dc5e50285c373b0a02bf6926197f4ad 100644 (file)
--- a/ras-events.h
+++ b/ras-events.h
@@ -24,6 +24,8 @@
 
 #include "types.h"
 
+extern char *choices_disable;
+
 struct mce_priv;
 struct ras_mc_offline_event;
 

diff --git a/rasdaemon.c b/rasdaemon.c
index 79b1605b4642034aad65d48974bd886dcd3ddaea..02e863e90912802c47dbdb0b3ae8663185199f81 100644 (file)
--- a/rasdaemon.c
+++ b/rasdaemon.c
@@ -35,7 +35,6 @@
 #define TOOL_DESCRIPTION "RAS daemon to log the RAS events."
 #define ARGS_DOC "<options>"
 #define DISABLE "DISABLE"
-char *choices_disable;
 
 const char *argp_program_version = TOOL_NAME " " VERSION;
 const char *argp_program_bug_address = "Mauro Carvalho Chehab <mchehab@kernel.org>";