drm/amdgpu: Replace kzalloc + copy_from_user with memdup_user

Replace kzalloc() followed by copy_from_user() with memdup_user() to
improve and simplify ta_if_load_debugfs_write() and
ta_if_invoke_debugfs_write().

No functional changes intended.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c
index 38face981c3e38779f4f93db6a0cdf739e6d60a8..6e8aad91bcd30541ac5195e2eca49a6434e45ee8 100644 (file)
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c
@@ -171,13 +171,9 @@ static ssize_t ta_if_load_debugfs_write(struct file *fp, const char *buf, size_t
 
        copy_pos += sizeof(uint32_t);
 
-       ta_bin = kzalloc(ta_bin_len, GFP_KERNEL);
-       if (!ta_bin)
-               return -ENOMEM;
-       if (copy_from_user((void *)ta_bin, &buf[copy_pos], ta_bin_len)) {
-               ret = -EFAULT;
-               goto err_free_bin;
-       }
+       ta_bin = memdup_user(&buf[copy_pos], ta_bin_len);
+       if (IS_ERR(ta_bin))
+               return PTR_ERR(ta_bin);
 
        /* Set TA context and functions */
        set_ta_context_funcs(psp, ta_type, &context);
@@ -327,13 +323,9 @@ static ssize_t ta_if_invoke_debugfs_write(struct file *fp, const char *buf, size
                return -EFAULT;
        copy_pos += sizeof(uint32_t);
 
-       shared_buf = kzalloc(shared_buf_len, GFP_KERNEL);
-       if (!shared_buf)
-               return -ENOMEM;
-       if (copy_from_user((void *)shared_buf, &buf[copy_pos], shared_buf_len)) {
-               ret = -EFAULT;
-               goto err_free_shared_buf;
-       }
+       shared_buf = memdup_user(&buf[copy_pos], shared_buf_len);
+       if (IS_ERR(shared_buf))
+               return PTR_ERR(shared_buf);
 
        set_ta_context_funcs(psp, ta_type, &context);