]> www.infradead.org Git - users/willy/linux.git/commitdiff
KVM: x86/xen: Remove extra unlock in kvm_xen_hvm_set_attr()
authorDavid Woodhouse <dwmw@amazon.co.uk>
Mon, 8 Feb 2021 23:23:26 +0000 (23:23 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 9 Feb 2021 12:42:03 +0000 (07:42 -0500)
This accidentally ended up locking and then immediately unlocking kvm->lock
at the beginning of the function. Fix it.

Fixes: a76b9641ad1c ("KVM: x86/xen: add KVM_XEN_HVM_SET_ATTR/KVM_XEN_HVM_GET_ATTR")
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Message-Id: <20210208232326.1830370-2-dwmw2@infradead.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/xen.c

index 39a7ffcdcf2280e329ba25590180b5099cbacc82..54a4895d4440d4abcb3f2571d1ac04f89b201048 100644 (file)
@@ -105,8 +105,6 @@ int kvm_xen_hvm_set_attr(struct kvm *kvm, struct kvm_xen_hvm_attr *data)
 
        mutex_lock(&kvm->lock);
 
-       mutex_unlock(&kvm->lock);
-
        switch (data->type) {
        case KVM_XEN_ATTR_TYPE_LONG_MODE:
                if (!IS_ENABLED(CONFIG_64BIT) && data->u.long_mode) {