KVM: TDX: Don't offline the last cpu of one package when there's TDX guest

Destroying TDX guest requires there's at least one cpu online for each
package, because reclaiming the TDX KeyID of the guest (as part of the
teardown process) requires to call some SEAMCALL (on any cpu) on all
packages.

Do not offline the last cpu of one package when there's any TDX guest
running, otherwise KVM may not be able to teardown TDX guest resulting
in leaking of TDX KeyID and other resources like TDX guest control
structure pages.

Implement the TDX version 'offline_cpu()' to prevent the cpu from going
offline if it is the last cpu on the package.

Co-developed-by: Kai Huang <kai.huang@intel.com>
Signed-off-by: Kai Huang <kai.huang@intel.com>
Suggested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
Reviewed-by: Binbin Wu <binbin.wu@linux.intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c
index b58a542fdf513503b99fef8364f7774e2359690a..303ecd30b8e25bd9105eeb32840f6c13741ea60d 100644 (file)
--- a/arch/x86/kvm/vmx/tdx.c
+++ b/arch/x86/kvm/vmx/tdx.c
@@ -131,10 +131,13 @@ static int init_kvm_tdx_caps(const struct tdx_sys_info_td_conf *td_conf,
  */
 static DEFINE_MUTEX(tdx_lock);
 
+static atomic_t nr_configured_hkid;
+
 static inline void tdx_hkid_free(struct kvm_tdx *kvm_tdx)
 {
        tdx_guest_keyid_free(kvm_tdx->hkid);
        kvm_tdx->hkid = -1;
+       atomic_dec(&nr_configured_hkid);
 }
 
 static inline bool is_hkid_assigned(struct kvm_tdx *kvm_tdx)
@@ -603,6 +606,8 @@ static int __tdx_td_init(struct kvm *kvm, struct td_params *td_params,
 
        ret = -ENOMEM;
 
+       atomic_inc(&nr_configured_hkid);
+
        tdr_page = alloc_page(GFP_KERNEL);
        if (!tdr_page)
                goto free_hkid;
@@ -900,6 +905,42 @@ static int tdx_online_cpu(unsigned int cpu)
        return r;
 }
 
+static int tdx_offline_cpu(unsigned int cpu)
+{
+       int i;
+
+       /* No TD is running.  Allow any cpu to be offline. */
+       if (!atomic_read(&nr_configured_hkid))
+               return 0;
+
+       /*
+        * In order to reclaim TDX HKID, (i.e. when deleting guest TD), need to
+        * call TDH.PHYMEM.PAGE.WBINVD on all packages to program all memory
+        * controller with pconfig.  If we have active TDX HKID, refuse to
+        * offline the last online cpu.
+        */
+       for_each_online_cpu(i) {
+               /*
+                * Found another online cpu on the same package.
+                * Allow to offline.
+                */
+               if (i != cpu && topology_physical_package_id(i) ==
+                               topology_physical_package_id(cpu))
+                       return 0;
+       }
+
+       /*
+        * This is the last cpu of this package.  Don't offline it.
+        *
+        * Because it's hard for human operator to understand the
+        * reason, warn it.
+        */
+#define MSG_ALLPKG_ONLINE \
+       "TDX requires all packages to have an online CPU. Delete all TDs in order to offline all CPUs of a package.\n"
+       pr_warn_ratelimited(MSG_ALLPKG_ONLINE);
+       return -EBUSY;
+}
+
 static void __do_tdx_cleanup(void)
 {
        /*
@@ -932,7 +973,7 @@ static int __init __do_tdx_bringup(void)
         */
        r = cpuhp_setup_state_cpuslocked(CPUHP_AP_ONLINE_DYN,
                                         "kvm/cpu/tdx:online",
-                                        tdx_online_cpu, NULL);
+                                        tdx_online_cpu, tdx_offline_cpu);
        if (r < 0)
                return r;