]> www.infradead.org Git - users/hch/misc.git/commitdiff
ARM: OMAP1: select CONFIG_GENERIC_IRQ_CHIP
authorArnd Bergmann <arnd@arndb.de>
Wed, 5 Feb 2025 12:11:33 +0000 (13:11 +0100)
committerArnd Bergmann <arnd@arndb.de>
Thu, 6 Mar 2025 15:36:03 +0000 (16:36 +0100)
When GENERIC_IRQ_CHIP is disabled, OMAP1 kernels fail to link:

arm-linux-gnueabi-ld: arch/arm/mach-omap1/irq.o: in function `omap1_init_irq':
irq.c:(.init.text+0x1e8): undefined reference to `irq_alloc_generic_chip'
arm-linux-gnueabi-ld: irq.c:(.init.text+0x228): undefined reference to `irq_setup_generic_chip'
arm-linux-gnueabi-ld: irq.c:(.init.text+0x2a8): undefined reference to `irq_gc_set_wake'
arm-linux-gnueabi-ld: irq.c:(.init.text+0x2b0): undefined reference to `irq_gc_mask_set_bit'
arm-linux-gnueabi-ld: irq.c:(.init.text+0x2b4): undefined reference to `irq_gc_mask_clr_bit'

This has apparently been the case for many years, but I never caught it
in randconfig builds until now, as there are dozens of other drivers
that also 'select GENERIC_IRQ_CHIP' and statistically there is almost
always one of them enabled.

Fixes: 55b447744389 ("ARM: OMAP1: Switch to use generic irqchip in preparation for sparse IRQ")
Link: https://lore.kernel.org/r/20250205121151.289535-1-arnd@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
arch/arm/mach-omap1/Kconfig

index a643b71e30a355decf4284015fc4fbcf1acd3283..08ec6bd84ada5698f4c0e0189b370e0a0b150dca 100644 (file)
@@ -8,6 +8,7 @@ menuconfig ARCH_OMAP1
        select ARCH_OMAP
        select CLKSRC_MMIO
        select FORCE_PCI if PCCARD
+       select GENERIC_IRQ_CHIP
        select GPIOLIB
        help
          Support for older TI OMAP1 (omap7xx, omap15xx or omap16xx)