]> www.infradead.org Git - users/hch/configfs.git/commitdiff
ASoC: amd: acp: add a null check for chip_pdev structure
authorVijendar Mukunda <Vijendar.Mukunda@amd.com>
Mon, 17 Jun 2024 07:28:34 +0000 (12:58 +0530)
committerMark Brown <broonie@kernel.org>
Wed, 19 Jun 2024 17:32:04 +0000 (18:32 +0100)
When acp platform device creation is skipped, chip->chip_pdev value will
remain NULL. Add NULL check for chip->chip_pdev structure in
snd_acp_resume() function to avoid null pointer dereference.

Fixes: 088a40980efb ("ASoC: amd: acp: add pm ops support for acp pci driver")
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Link: https://msgid.link/r/20240617072844.871468-1-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp/acp-pci.c

index ad320b29e87dcb1e0b3fe3a949ab32e4d765cf95..aa3e72d134518a9d6b2a49d20fc1b97d54486dcd 100644 (file)
@@ -199,10 +199,12 @@ static int __maybe_unused snd_acp_resume(struct device *dev)
        ret = acp_init(chip);
        if (ret)
                dev_err(dev, "ACP init failed\n");
-       child = chip->chip_pdev->dev;
-       adata = dev_get_drvdata(&child);
-       if (adata)
-               acp_enable_interrupts(adata);
+       if (chip->chip_pdev) {
+               child = chip->chip_pdev->dev;
+               adata = dev_get_drvdata(&child);
+               if (adata)
+                       acp_enable_interrupts(adata);
+       }
        return ret;
 }