]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR
authorMarkus Armbruster <armbru@redhat.com>
Wed, 28 May 2014 09:17:03 +0000 (11:17 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 5 Aug 2014 16:41:26 +0000 (11:41 -0500)
Introduced in commit a8d8ecb.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit f25391c2a6ef1674384204265429520ea50e82bc)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block/qapi.c

index 8f2b4dbe7d07fd455995bfc2682f97aa2005e95c..a69c00d4b18bea26fa2824cfd6bc769fcbc06d49 100644 (file)
@@ -474,6 +474,7 @@ static void dump_qobject(fprintf_function func_fprintf, void *f,
         case QTYPE_QERROR: {
             QString *value = qerror_human((QError *)obj);
             func_fprintf(f, "%s", qstring_get_str(value));
+            QDECREF(value);
             break;
         }
         case QTYPE_NONE: