crypto: hisilicon/hpre - fix dma unmap sequence

Perform DMA unmapping operations before processing data.
Otherwise, there may be unsynchronized data accessed by
the CPU when the SWIOTLB is enabled.

Signed-off-by: Zhiqi Song <songzhiqi1@huawei.com>
Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
index 61b5e1c5d0192c17894b7cb60f568e51151dbecb..1550c3818383ab38bf12645fb99a3c8d02d92cab 100644 (file)
--- a/drivers/crypto/hisilicon/hpre/hpre_crypto.c
+++ b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
@@ -1491,11 +1491,13 @@ static void hpre_ecdh_cb(struct hpre_ctx *ctx, void *resp)
        if (overtime_thrhld && hpre_is_bd_timeout(req, overtime_thrhld))
                atomic64_inc(&dfx[HPRE_OVER_THRHLD_CNT].value);
 
+       /* Do unmap before data processing */
+       hpre_ecdh_hw_data_clr_all(ctx, req, areq->dst, areq->src);
+
        p = sg_virt(areq->dst);
        memmove(p, p + ctx->key_sz - curve_sz, curve_sz);
        memmove(p + curve_sz, p + areq->dst_len - curve_sz, curve_sz);
 
-       hpre_ecdh_hw_data_clr_all(ctx, req, areq->dst, areq->src);
        kpp_request_complete(areq, ret);
 
        atomic64_inc(&dfx[HPRE_RECV_CNT].value);
@@ -1808,9 +1810,11 @@ static void hpre_curve25519_cb(struct hpre_ctx *ctx, void *resp)
        if (overtime_thrhld && hpre_is_bd_timeout(req, overtime_thrhld))
                atomic64_inc(&dfx[HPRE_OVER_THRHLD_CNT].value);
 
+       /* Do unmap before data processing */
+       hpre_curve25519_hw_data_clr_all(ctx, req, areq->dst, areq->src);
+
        hpre_key_to_big_end(sg_virt(areq->dst), CURVE25519_KEY_SIZE);
 
-       hpre_curve25519_hw_data_clr_all(ctx, req, areq->dst, areq->src);
        kpp_request_complete(areq, ret);
 
        atomic64_inc(&dfx[HPRE_RECV_CNT].value);