ext4: replace min/max nesting with clamp()

The clamp() macro explicitly expresses the intent of constraining a value
within bounds.Therefore, replacing max(min(a,b),c) with clamp(val, lo, hi)
can improve code readability.

Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
index 51661570cf3b8df7fbcae6e8d13a43acfac83d1d..ab1ff51302fbd062ba8543fcdd3809eba9b4bc3c 100644 (file)
--- a/fs/ext4/mmp.c
+++ b/fs/ext4/mmp.c
@@ -231,9 +231,9 @@ static int kmmpd(void *data)
                 * Adjust the mmp_check_interval depending on how much time
                 * it took for the MMP block to be written.
                 */
-               mmp_check_interval = max(min(EXT4_MMP_CHECK_MULT * diff / HZ,
-                                            EXT4_MMP_MAX_CHECK_INTERVAL),
-                                        EXT4_MMP_MIN_CHECK_INTERVAL);
+               mmp_check_interval = clamp(EXT4_MMP_CHECK_MULT * diff / HZ,
+                                          EXT4_MMP_MIN_CHECK_INTERVAL,
+                                          EXT4_MMP_MAX_CHECK_INTERVAL);
                mmp->mmp_check_interval = cpu_to_le16(mmp_check_interval);
        }