]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
media: sunxi: sun8i-rotate.c: remove useless error message
authorDaniel W. S. Almeida <dwlsalmeida@gmail.com>
Fri, 7 Aug 2020 08:35:28 +0000 (10:35 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sat, 29 Aug 2020 05:47:04 +0000 (07:47 +0200)
This fixes the following coccinelle report:

drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c:751:2-9:
line 751 is redundant because platform_get_irq() already prints an error

By removing the useless call to dev_err()

Found using - Coccinelle (http://coccinelle.lip6.fr)

Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c

index 94f505d3cbadccd6f57b5d0f0c7e3af4e085be4c..3f81dd17755cb68b3dd917b5f84314b1ee4b5d35 100644 (file)
@@ -747,11 +747,8 @@ static int rotate_probe(struct platform_device *pdev)
        dev->dev = &pdev->dev;
 
        irq = platform_get_irq(pdev, 0);
-       if (irq <= 0) {
-               dev_err(dev->dev, "Failed to get IRQ\n");
-
+       if (irq <= 0)
                return irq;
-       }
 
        ret = devm_request_irq(dev->dev, irq, rotate_irq,
                               0, dev_name(dev->dev), dev);