]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
wifi: mwifiex: Convert to use jiffies macro
authorChen Yufan <chenyufan@vivo.com>
Fri, 23 Aug 2024 07:03:19 +0000 (15:03 +0800)
committerKalle Valo <kvalo@kernel.org>
Tue, 3 Sep 2024 18:31:24 +0000 (21:31 +0300)
Use time_after macro instead of using jiffies directly to handle wraparound.
Change the type to to unsigned long to avoid unnecessary casts.

Signed-off-by: Chen Yufan <chenyufan@vivo.com>
Acked-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20240823070320.430753-1-chenyufan@vivo.com
drivers/net/wireless/marvell/mwifiex/main.h
drivers/net/wireless/marvell/mwifiex/tdls.c

index 529863edd7a25745370bc391c7c42fd4b19d197c..566adce3413cb6604abb02245325116bb9fb37bd 100644 (file)
@@ -799,7 +799,7 @@ struct mwifiex_auto_tdls_peer {
        u8 mac_addr[ETH_ALEN];
        u8 tdls_status;
        int rssi;
-       long rssi_jiffies;
+       unsigned long rssi_jiffies;
        u8 failure_count;
        u8 do_discover;
        u8 do_setup;
index 6c60621b6cccb581ea045051fbcb67506ae90c6f..7823e67694e888b0999482ea19aaf104665d1063 100644 (file)
@@ -1439,8 +1439,8 @@ void mwifiex_check_auto_tdls(struct timer_list *t)
 
        spin_lock_bh(&priv->auto_tdls_lock);
        list_for_each_entry(tdls_peer, &priv->auto_tdls_list, list) {
-               if ((jiffies - tdls_peer->rssi_jiffies) >
-                   (MWIFIEX_AUTO_TDLS_IDLE_TIME * HZ)) {
+               if (time_after(jiffies, tdls_peer->rssi_jiffies +
+                                        MWIFIEX_AUTO_TDLS_IDLE_TIME * HZ)) {
                        tdls_peer->rssi = 0;
                        tdls_peer->do_discover = true;
                        priv->check_tdls_tx = true;