]> www.infradead.org Git - mtd-utils.git/commitdiff
mkfs.ubifs: simplify make_path with xasprintf
authorSascha Hauer <s.hauer@pengutronix.de>
Thu, 12 Nov 2015 09:31:26 +0000 (10:31 +0100)
committerRichard Weinberger <richard@nod.at>
Thu, 12 Nov 2015 09:50:04 +0000 (10:50 +0100)
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Daniel Walter <dwalter@sigma-star.at>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Richard Weinberger <richard@nod.at>
ubifs-utils/mkfs.ubifs/mkfs.ubifs.c

index 049219b52cc58304ccb536036f08b5b7fa1844de..a99c6138230482765c7ea3c436bbd17df646278c 100644 (file)
@@ -227,13 +227,9 @@ static char *make_path(const char *dir, const char *name)
 {
        char *s;
 
-       s = malloc(strlen(dir) + strlen(name) + 2);
-       if (!s)
-               return NULL;
-       strcpy(s, dir);
-       if (dir[strlen(dir) - 1] != '/')
-               strcat(s, "/");
-       strcat(s, name);
+       xasprintf(&s, "%s%s%s",
+                 dir, dir[strlen(dir) - 1] == '/' ? "" : "/", name);
+
        return s;
 }