]> www.infradead.org Git - users/willy/linux.git/commitdiff
drm/i915/dp: Make .set_idle_link_train() mandatory
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 10 Jul 2025 20:17:18 +0000 (23:17 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 17 Jul 2025 16:42:16 +0000 (19:42 +0300)
Everyone implements the .set_idle_link_train() hook now.
Just make it mandatory.

Tested-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250710201718.25310-8-ville.syrjala@linux.intel.com
drivers/gpu/drm/i915/display/intel_dp_link_training.c

index cb3870427f3fc2fa2661fdc4379da22bfca01802..344b74109a83038ae0b74402ab42eb04447bfe5c 100644 (file)
@@ -1138,9 +1138,6 @@ void intel_dp_stop_link_train(struct intel_dp *intel_dp,
 
        intel_dp->link.active = true;
 
-       if (!intel_dp->set_idle_link_train)
-               intel_dp_disable_dpcd_training_pattern(intel_dp, DP_PHY_DPRX);
-
        intel_dp_program_link_training_pattern(intel_dp, crtc_state, DP_PHY_DPRX,
                                               DP_TRAINING_PATTERN_DISABLE);
 
@@ -1381,10 +1378,8 @@ intel_dp_link_train_all_phys(struct intel_dp *intel_dp,
        if (ret)
                ret = intel_dp_link_train_phy(intel_dp, crtc_state, DP_PHY_DPRX);
 
-       if (intel_dp->set_idle_link_train) {
-               intel_dp_disable_dpcd_training_pattern(intel_dp, DP_PHY_DPRX);
-               intel_dp->set_idle_link_train(intel_dp, crtc_state);
-       }
+       intel_dp_disable_dpcd_training_pattern(intel_dp, DP_PHY_DPRX);
+       intel_dp->set_idle_link_train(intel_dp, crtc_state);
 
        return ret;
 }