]> www.infradead.org Git - users/sagi/libnvme.git/commitdiff
fabrics: Do not ignore one char whitespace when string sanitizing
authorDaniel Wagner <dwagner@suse.de>
Tue, 7 Feb 2023 08:30:42 +0000 (09:30 +0100)
committerDaniel Wagner <dwagner@suse.de>
Tue, 7 Feb 2023 08:30:42 +0000 (09:30 +0100)
strchomp() is handling the max length of a string correctly.

Reported-by: calebsander
Signed-off-by: Daniel Wagner <dwagner@suse.de>
src/nvme/fabrics.c

index 7134dbae8decf9f62c6f12b43cb87ff90c4f9498..1c2521681dfe701d09071aff019ee43c2d913879 100644 (file)
@@ -894,20 +894,20 @@ static void sanitize_discovery_log_entry(struct nvmf_disc_log_entry  *e)
                switch (e->adrfam) {
                case NVMF_ADDR_FAMILY_IP4:
                case NVMF_ADDR_FAMILY_IP6:
-                       strchomp(e->traddr, NVMF_TRADDR_SIZE - 1);
-                       strchomp(e->trsvcid, NVMF_TRSVCID_SIZE - 1);
+                       strchomp(e->traddr, NVMF_TRADDR_SIZE);
+                       strchomp(e->trsvcid, NVMF_TRSVCID_SIZE);
                        break;
                }
                break;
         case NVMF_TRTYPE_FC:
                switch (e->adrfam) {
                case NVMF_ADDR_FAMILY_FC:
-                       strchomp(e->traddr, NVMF_TRADDR_SIZE - 1);
+                       strchomp(e->traddr, NVMF_TRADDR_SIZE);
                        break;
                }
                break;
        case NVMF_TRTYPE_LOOP:
-               strchomp(e->traddr, NVMF_TRADDR_SIZE - 1);
+               strchomp(e->traddr, NVMF_TRADDR_SIZE);
                break;
        }
 }