]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drm/nouveau/pm: Annotate struct nvkm_perfdom with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 22 Sep 2023 17:32:10 +0000 (10:32 -0700)
committerChristian König <christian.koenig@amd.com>
Thu, 5 Oct 2023 09:30:50 +0000 (11:30 +0200)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct nvkm_perfdom.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230922173216.3823169-5-keescook@chromium.org
drivers/gpu/drm/nouveau/nvkm/engine/pm/priv.h

index 6ae25d3e7f45c814759f8881827550dd80bde39a..c011227f705295c166585e7eedb59e296896954a 100644 (file)
@@ -82,7 +82,7 @@ struct nvkm_perfdom {
        u8  mode;
        u32 clk;
        u16 signal_nr;
-       struct nvkm_perfsig signal[];
+       struct nvkm_perfsig signal[] __counted_by(signal_nr);
 };
 
 struct nvkm_funcdom {