ath10k: Fix error handling in ath10k_setup_msa_resources

The device_node pointer is returned by of_parse_phandle() with refcount
incremented. We should use of_node_put() on it when done.

This function only calls of_node_put() in the regular path.
And it will cause refcount leak in error path.

Fixes: 727fec790ead ("ath10k: Setup the msa resources before qmi init")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20220308070238.19295-1-linmq006@gmail.com

diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
index 681e1abe74400afda575449d5003051294e5abae..8328966a0471c6830b98e8ede61e45de03244562 100644 (file)
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -1551,11 +1551,11 @@ static int ath10k_setup_msa_resources(struct ath10k *ar, u32 msa_size)
        node = of_parse_phandle(dev->of_node, "memory-region", 0);
        if (node) {
                ret = of_address_to_resource(node, 0, &r);
+               of_node_put(node);
                if (ret) {
                        dev_err(dev, "failed to resolve msa fixed region\n");
                        return ret;
                }
-               of_node_put(node);
 
                ar->msa.paddr = r.start;
                ar->msa.mem_size = resource_size(&r);