usb: ehci-hcd: fix call balance of clocks handling routines

If the clocks priv->iclk and priv->fclk were not enabled in ehci_hcd_sh_probe,
they should not be disabled in any path.

Conversely, if they was enabled in ehci_hcd_sh_probe, they must be disabled
in all error paths to ensure proper cleanup.

Found by Linux Verification Center (linuxtesting.org) with Klever.

Fixes: 63c845522263 ("usb: ehci-hcd: Add support for SuperH EHCI.")
Cc: stable@vger.kernel.org # ff30bd6a6618: sh: clk: Fix clk_enable() to return 0 on NULL clk
Signed-off-by: Vitalii Mordan <mordan@ispras.ru>
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20241121114700.2100520-1-mordan@ispras.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/host/ehci-sh.c b/drivers/usb/host/ehci-sh.c
index 5d0d972fb7b1b4f3ab9dca0d66b5c199319ea548..2d23690d72c507ac8cf788227c9b807b65e173e0 100644 (file)
--- a/drivers/usb/host/ehci-sh.c
+++ b/drivers/usb/host/ehci-sh.c
@@ -119,8 +119,12 @@ static int ehci_hcd_sh_probe(struct platform_device *pdev)
        if (IS_ERR(priv->iclk))
                priv->iclk = NULL;
 
-       clk_enable(priv->fclk);
-       clk_enable(priv->iclk);
+       ret = clk_enable(priv->fclk);
+       if (ret)
+               goto fail_request_resource;
+       ret = clk_enable(priv->iclk);
+       if (ret)
+               goto fail_iclk;
 
        ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
        if (ret != 0) {
@@ -136,6 +140,7 @@ static int ehci_hcd_sh_probe(struct platform_device *pdev)
 
 fail_add_hcd:
        clk_disable(priv->iclk);
+fail_iclk:
        clk_disable(priv->fclk);
 
 fail_request_resource: