]> www.infradead.org Git - users/willy/linux.git/commitdiff
usb: gadget: udc: atmel: remove outdated comment in usba_ep_disable()
authorMichał Mirosław <mirq-linux@rere.qmqm.pl>
Thu, 28 May 2020 18:35:53 +0000 (20:35 +0200)
committerFelipe Balbi <balbi@kernel.org>
Thu, 9 Jul 2020 07:13:07 +0000 (10:13 +0300)
Fixed commit removed the offending behaviour from the driver, but missed
the comment and associated test. Remove them now.

Fixes: 38e58986e6fc ("usb: gadget: udc: atmel: don't disable enpdoints we don't own")
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
drivers/usb/gadget/udc/atmel_usba_udc.c

index d69f61ff018193d689f64936140d4858b9d41211..9153e220848de9252b568d3e98fe46b01f91b513 100644 (file)
@@ -676,13 +676,7 @@ static int usba_ep_disable(struct usb_ep *_ep)
 
        if (!ep->ep.desc) {
                spin_unlock_irqrestore(&udc->lock, flags);
-               /* REVISIT because this driver disables endpoints in
-                * reset_all_endpoints() before calling disconnect(),
-                * most gadget drivers would trigger this non-error ...
-                */
-               if (udc->gadget.speed != USB_SPEED_UNKNOWN)
-                       DBG(DBG_ERR, "ep_disable: %s not enabled\n",
-                                       ep->ep.name);
+               DBG(DBG_ERR, "ep_disable: %s not enabled\n", ep->ep.name);
                return -EINVAL;
        }
        ep->ep.desc = NULL;