gpiolib: don't bail out if get_direction() fails in gpiochip_add_data()

Since commit 9d846b1aebbe ("gpiolib: check the return value of
gpio_chip::get_direction()") we check the return value of the
get_direction() callback as per its API contract. Some drivers have been
observed to fail to register now as they may call get_direction() in
gpiochip_add_data() in contexts where it has always silently failed.
Until we audit all drivers, replace the bail-out to a kernel log
warning.

Fixes: 9d846b1aebbe ("gpiolib: check the return value of gpio_chip::get_direction()")
Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://lore.kernel.org/all/Z7VFB1nST6lbmBIo@finisterre.sirena.org.uk/
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Closes: https://lore.kernel.org/all/dfe03f88-407e-4ef1-ad30-42db53bbd4e4@samsung.com/
Tested-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Mark Brown <broonie@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/20250219144356.258635-1-brgl@bgdev.pl
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 5529d8b65f6fba207dbd0583b1b84b2917b55c20..fc19df5a64c2be5ce71d8eb115a2a9b522ce70de 100644 (file)
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1059,7 +1059,15 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
                if (gc->get_direction && gpiochip_line_is_valid(gc, desc_index)) {
                        ret = gc->get_direction(gc, desc_index);
                        if (ret < 0)
-                               goto err_cleanup_desc_srcu;
+                               /*
+                                * FIXME: Bail-out here once all GPIO drivers
+                                * are updated to not return errors in
+                                * situations that can be considered normal
+                                * operation.
+                                */
+                               dev_warn(&gdev->dev,
+                                        "%s: get_direction failed: %d\n",
+                                        __func__, ret);
 
                        assign_bit(FLAG_IS_OUT, &desc->flags, !ret);
                } else {