]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
arm64: dts: qcom: sc7180-trogdor: mark bluetooth address as broken
authorJohan Hovold <johan+linaro@kernel.org>
Wed, 20 Mar 2024 07:55:52 +0000 (08:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:19:36 +0000 (16:19 +0200)
commit e12e28009e584c8f8363439f6a928ec86278a106 upstream.

Several Qualcomm Bluetooth controllers lack persistent storage for the
device address and instead one can be provided by the boot firmware
using the 'local-bd-address' devicetree property.

The Bluetooth bindings clearly states that the address should be
specified in little-endian order, but due to a long-standing bug in the
Qualcomm driver which reversed the address some boot firmware has been
providing the address in big-endian order instead.

The boot firmware in SC7180 Trogdor Chromebooks is known to be affected
so mark the 'local-bd-address' property as broken to maintain backwards
compatibility with older firmware when fixing the underlying driver bug.

Note that ChromeOS always updates the kernel and devicetree in lockstep
so that there is no need to handle backwards compatibility with older
devicetrees.

Fixes: 7ec3e67307f8 ("arm64: dts: qcom: sc7180-trogdor: add initial trogdor and lazor dt")
Cc: stable@vger.kernel.org # 5.10
Cc: Rob Clark <robdclark@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Acked-by: Bjorn Andersson <andersson@kernel.org>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi

index a9d36ac6cb90e206a23ba1f176f9d6757f41b2c4..a88798b809212c72d6f5cfb0c7e3c830672ac30c 100644 (file)
@@ -911,6 +911,8 @@ ap_spi_fp: &spi10 {
                vddrf-supply = <&pp1300_l2c>;
                vddch0-supply = <&pp3300_l10c>;
                max-speed = <3200000>;
+
+               qcom,local-bd-address-broken;
        };
 };