]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
selftests/bpf: Fix bpf_nf selftest failure
authorSaket Kumar Bhaskar <skb99@linux.ibm.com>
Wed, 9 Apr 2025 09:56:33 +0000 (15:26 +0530)
committerAndrii Nakryiko <andrii@kernel.org>
Wed, 9 Apr 2025 23:29:39 +0000 (16:29 -0700)
For systems with missing iptables-legacy tool this selftest fails.

Add check to find if iptables-legacy tool is available and skip the
test if the tool is missing.

Fixes: de9c8d848d90 ("selftests/bpf: S/iptables/iptables-legacy/ in the bpf_nf and xdp_synproxy test")
Signed-off-by: Saket Kumar Bhaskar <skb99@linux.ibm.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20250409095633.33653-1-skb99@linux.ibm.com
tools/testing/selftests/bpf/prog_tests/bpf_nf.c

index dbd13f8e42a7aa712cb58dbffd484f5e373609ab..dd6512fa652be08e10526193933b52b183bd76af 100644 (file)
@@ -63,6 +63,12 @@ static void test_bpf_nf_ct(int mode)
                .repeat = 1,
        );
 
+       if (SYS_NOFAIL("iptables-legacy --version")) {
+               fprintf(stdout, "Missing required iptables-legacy tool\n");
+               test__skip();
+               return;
+       }
+
        skel = test_bpf_nf__open_and_load();
        if (!ASSERT_OK_PTR(skel, "test_bpf_nf__open_and_load"))
                return;