]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
selftests: mptcp: userspace_pm: report errors with 'remove' tests
authorMatthieu Baerts <matthieu.baerts@tessares.net>
Tue, 4 Jul 2023 20:44:39 +0000 (22:44 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 5 Jul 2023 09:51:14 +0000 (10:51 +0100)
A message was mentioning an issue with the "remove" tests but the
selftest was not marked as failed.

Directly exit with an error like it is done everywhere else in this
selftest.

Link: https://github.com/multipath-tcp/mptcp_net-next/issues/368
Fixes: 259a834fadda ("selftests: mptcp: functional tests for the userspace PM type")
Cc: stable@vger.kernel.org
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/mptcp/userspace_pm.sh

index 841a67a7d52432f83426aea7373c2f0cd94dd87a..b180133a30af725d53322e03fe779d670618c0fe 100755 (executable)
@@ -423,6 +423,7 @@ test_remove()
                stdbuf -o0 -e0 printf "[OK]\n"
        else
                stdbuf -o0 -e0 printf "[FAIL]\n"
+               exit 1
        fi
 
        # RM_ADDR using an invalid addr id should result in no action
@@ -437,6 +438,7 @@ test_remove()
                stdbuf -o0 -e0 printf "[OK]\n"
        else
                stdbuf -o0 -e0 printf "[FAIL]\n"
+               exit 1
        fi
 
        # RM_ADDR from the client to server machine